[MediaWiki-commits] [Gerrit] mediawiki...BlueSpiceInsertLink[master]: Add php-parallel-lint, grunt-jsonlint and grunt-banana-checker

Umherirrender (Code Review)

2017-12-31 11:48:07 UTC

Umherirrender has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/401165 )

Change subject: Add php-parallel-lint, grunt-jsonlint and grunt-banana-checker
......................................................................

Add php-parallel-lint, grunt-jsonlint and grunt-banana-checker

jsonlint and banana-checker will test for valid i18n files
php-lint will test for valid php files

Change-Id: I63cfd2a8778e0fb7b98608279716a85c1ddaef45
---
M .gitignore
A Gruntfile.js
M composer.json
A package.json
4 files changed, 42 insertions(+), 1 deletion(-)

Approvals:
Umherirrender: Verified; Looks good to me, approved

diff --git a/.gitignore b/.gitignore
index 463cbe5..553a300 100644
--- a/.gitignore
+++ b/.gitignore
@@ -2,7 +2,9 @@
*.kate-swp
*.swp
node_modules/**
-vendor/composer/**
+vendor/**
+!vendor/src/**
+!vendor/bsFileLinkChooser.jar

composer.lock
composer.phar
diff --git a/Gruntfile.js b/Gruntfile.js
new file mode 100644
index 0000000..ea67e84
--- /dev/null
+++ b/Gruntfile.js
@@ -0,0 +1,19 @@
+module.exports = function ( grunt ) {
+ grunt.loadNpmTasks( 'grunt-jsonlint' );
+ grunt.loadNpmTasks( 'grunt-banana-checker' );
+
+ var conf = grunt.file.readJSON( 'extension.json' );
+ grunt.initConfig( {
+ banana: conf.MessagesDirs,
+ jsonlint: {
+ all: [
+ '**/*.json',
+ '!node_modules/**',
+ '!vendor/**'
+ ]
+ }
+ } );
+
+ grunt.registerTask( 'test', [ 'jsonlint', 'banana' ] );
+ grunt.registerTask( 'default', 'test' );
+};
diff --git a/composer.json b/composer.json
index 27e4ea2..d31c959 100644
--- a/composer.json
+++ b/composer.json
@@ -6,6 +6,15 @@
"require": {
"composer/installers": "~1.0"
},
+ "require-dev": {
+ "jakub-onderka/php-parallel-lint": "0.9.2",
+ "jakub-onderka/php-console-highlighter": "0.3.2"
+ },
+ "scripts": {
+ "test": [
+ "parallel-lint . --exclude vendor --exclude node_modules"
+ ]
+ },
"autoload": {
"psr-4": {
}
diff --git a/package.json b/package.json
new file mode 100644
index 0000000..10fa9bc
--- /dev/null
+++ b/package.json
@@ -0,0 +1,11 @@
+{
+ "private": true,
+ "scripts": {
+ "test": "grunt test"
+ },
+ "devDependencies": {
+ "grunt": "1.0.1",
+ "grunt-banana-checker": "0.6.0",
+ "grunt-jsonlint": "1.1.0"
+ }
+}
--
To view, visit https://gerrit.wikimedia.org/r/401165
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I63cfd2a8778e0fb7b98608279716a85c1ddaef45
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceInsertLink
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <***@web.de>
Gerrit-Reviewer: Ljonka <***@gmail.com>
Gerrit-Reviewer: Mglaser <***@hallowelt.biz>
Gerrit-Reviewer: Pwirth <***@hallowelt.biz>
Gerrit-Reviewer: Robert Vogel <***@hallowelt.biz>
Gerrit-Reviewer: Umherirrender <***@web.de>