[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Parser: extract $title, follow-up 3d560be428

[Legoktm (Code Review)]

Legoktm has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401052 )

Change subject: Parser: extract $title, follow-up 3d560be428
......................................................................

Parser: extract $title, follow-up 3d560be428

In the conversion away from extract(), the $title variable was missed. This
broke LabeledSectionTransclusion.

Change-Id: If4c140aedf16fc16a4ae2361f465798055748255
---
M includes/parser/Parser.php
1 file changed, 3 insertions(+), 0 deletions(-)


git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/52/401052/1

diff --git a/includes/parser/Parser.php b/includes/parser/Parser.php
index 078de3c..e7e7aa0 100644
--- a/includes/parser/Parser.php
+++ b/includes/parser/Parser.php
@@ -3115,6 +3115,9 @@
}

// Extract any forwarded flags
+ if ( isset( $result['title'] ) ) {
+ $title = $result['title'];
+ }
if ( isset( $result['found'] ) ) {
$found = $result['found'];
}
--
To view, visit https://gerrit.wikimedia.org/r/401052
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If4c140aedf16fc16a4ae2361f465798055748255
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Legoktm <***@member.fsf.org>

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/401052 )

Change subject: Parser: extract $title, follow-up 3d560be428
......................................................................


Parser: extract $title, follow-up 3d560be428

In the conversion away from extract(), the $title variable was missed. This
broke LabeledSectionTransclusion.

Change-Id: If4c140aedf16fc16a4ae2361f465798055748255
---
M includes/parser/Parser.php
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
Umherirrender: Looks good to me, approved
jenkins-bot: Verified
Tpt: Looks good to me, but someone else must approve



diff --git a/includes/parser/Parser.php b/includes/parser/Parser.php
index 078de3c..e7e7aa0 100644
--- a/includes/parser/Parser.php
+++ b/includes/parser/Parser.php
@@ -3115,6 +3115,9 @@
}

// Extract any forwarded flags
+ if ( isset( $result['title'] ) ) {
+ $title = $result['title'];
+ }
if ( isset( $result['found'] ) ) {
$found = $result['found'];
}
--
To view, visit https://gerrit.wikimedia.org/r/401052
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If4c140aedf16fc16a4ae2361f465798055748255
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Legoktm <***@member.fsf.org>
Gerrit-Reviewer: C. Scott Ananian <***@wikimedia.org>
Gerrit-Reviewer: Jackmcbarn <***@gmail.com>
Gerrit-Reviewer: Tpt <***@hotmail.fr>
Gerrit-Reviewer: Umherirrender <***@web.de>
Gerrit-Reviewer: jenkins-bot <>