Discussion:
[MediaWiki-commits] [Gerrit] mediawiki...Timeless[master]: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0
Umherirrender (Code Review)
2017-12-30 22:08:47 UTC
Permalink
Umherirrender has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401099 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0
......................................................................

build: Updating mediawiki/mediawiki-codesniffer to 15.0.0

Change-Id: I4e5f3311af0f11905b8748be71b5fa8e5e5690a7
---
M .phpcs.xml
M composer.json
2 files changed, 3 insertions(+), 1 deletion(-)


git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Timeless refs/changes/99/401099/1

diff --git a/.phpcs.xml b/.phpcs.xml
index 3797dd8..9d8c0d6 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -2,6 +2,8 @@
<ruleset>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude name="MediaWiki.Commenting.FunctionComment.MissingParamComment"/>
+ <exclude name="Squiz.Scope.MemberVarScope.Missing"/>
+ <exclude name="Squiz.Scope.MethodScope.Missing"/>
</rule>
<file>.</file>
<arg name="extensions" value="php,php5,inc"/>
diff --git a/composer.json b/composer.json
index 4756a8a..e450f2e 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
{
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
- "mediawiki/mediawiki-codesniffer": "14.1.0",
+ "mediawiki/mediawiki-codesniffer": "15.0.0",
"jakub-onderka/php-console-highlighter": "0.3.2",
"mediawiki/minus-x": "0.2.1"
},
--
To view, visit https://gerrit.wikimedia.org/r/401099
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4e5f3311af0f11905b8748be71b5fa8e5e5690a7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Timeless
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <***@web.de>
jenkins-bot (Code Review)
2017-12-30 22:18:37 UTC
Permalink
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/401099 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0
......................................................................


build: Updating mediawiki/mediawiki-codesniffer to 15.0.0

Change-Id: I4e5f3311af0f11905b8748be71b5fa8e5e5690a7
---
M .phpcs.xml
M composer.json
2 files changed, 3 insertions(+), 1 deletion(-)

Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified



diff --git a/.phpcs.xml b/.phpcs.xml
index 3797dd8..9d8c0d6 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -2,6 +2,8 @@
<ruleset>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude name="MediaWiki.Commenting.FunctionComment.MissingParamComment"/>
+ <exclude name="Squiz.Scope.MemberVarScope.Missing"/>
+ <exclude name="Squiz.Scope.MethodScope.Missing"/>
</rule>
<file>.</file>
<arg name="extensions" value="php,php5,inc"/>
diff --git a/composer.json b/composer.json
index 4756a8a..e450f2e 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
{
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
- "mediawiki/mediawiki-codesniffer": "14.1.0",
+ "mediawiki/mediawiki-codesniffer": "15.0.0",
"jakub-onderka/php-console-highlighter": "0.3.2",
"mediawiki/minus-x": "0.2.1"
},
--
To view, visit https://gerrit.wikimedia.org/r/401099
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4e5f3311af0f11905b8748be71b5fa8e5e5690a7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Timeless
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <***@web.de>
Gerrit-Reviewer: Legoktm <***@member.fsf.org>
Gerrit-Reviewer: Umherirrender <***@web.de>
Gerrit-Reviewer: jenkins-bot <>
Loading...