Thiemo Kreuz (WMDE) (Code Review)
2017-12-28 15:13:53 UTC
Thiemo Kreuz (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400583 )
Change subject: Remove self-explaining "section heading" comments from classes
......................................................................
Remove self-explaining "section heading" comments from classes
I can see that "parent::__construct" literally calls the parent
constructor. I can see that stuff preceeded by the keyword "protected"
is protected. I really (really) don't need comments explaining such.
Change-Id: I7458e714976a6acd3ba6a7c93fdc27d03903df83
---
M includes/Linker.php
M includes/actions/WatchAction.php
M includes/context/RequestContext.php
M includes/htmlform/HTMLFormElement.php
M includes/libs/CSSMin.php
M includes/libs/JavaScriptMinifier.php
M includes/resourceloader/ResourceLoader.php
M includes/resourceloader/ResourceLoaderFileModule.php
M includes/resourceloader/ResourceLoaderFilePath.php
M includes/resourceloader/ResourceLoaderModule.php
M includes/resourceloader/ResourceLoaderUserTokensModule.php
M includes/specials/pagers/ProtectedPagesPager.php
M includes/widget/ComplexNamespaceInputWidget.php
M includes/widget/ComplexTitleInputWidget.php
M includes/widget/DateInputWidget.php
M includes/widget/DateTimeInputWidget.php
M includes/widget/NamespaceInputWidget.php
M includes/widget/SearchInputWidget.php
M includes/widget/SelectWithInputWidget.php
M includes/widget/TitleInputWidget.php
M includes/widget/UserInputWidget.php
21 files changed, 4 insertions(+), 50 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/83/400583/1
diff --git a/includes/Linker.php b/includes/Linker.php
index 84e3103..c0255ac 100644
--- a/includes/Linker.php
+++ b/includes/Linker.php
@@ -2124,8 +2124,6 @@
return Xml::tags( 'span', [ 'class' => 'mw-revdelundel-link' ], $htmlParentheses );
}
- /* Deprecated methods */
-
/**
* Returns the attributes for the tooltip and access key.
*
diff --git a/includes/actions/WatchAction.php b/includes/actions/WatchAction.php
index e12a727..528e0e2 100644
--- a/includes/actions/WatchAction.php
+++ b/includes/actions/WatchAction.php
@@ -80,8 +80,6 @@
$this->getOutput()->addWikiMsg( $msgKey, $this->getTitle()->getPrefixedText() );
}
- /* Static utility methods */
-
/**
* Watch or unwatch a page
* @since 1.22
diff --git a/includes/context/RequestContext.php b/includes/context/RequestContext.php
index c2d0de1..652f068 100644
--- a/includes/context/RequestContext.php
+++ b/includes/context/RequestContext.php
@@ -441,8 +441,6 @@
return $this->skin;
}
- /** Helpful methods **/
-
/**
* Get a Message object with context set
* Parameters are the same as wfMessage()
@@ -457,8 +455,6 @@
return call_user_func_array( 'wfMessage', $args )->setContext( $this );
}
-
- /** Static methods **/
/**
* Get the RequestContext object associated with the main request
diff --git a/includes/htmlform/HTMLFormElement.php b/includes/htmlform/HTMLFormElement.php
index 10db90c..66d6143 100644
--- a/includes/htmlform/HTMLFormElement.php
+++ b/includes/htmlform/HTMLFormElement.php
@@ -38,8 +38,8 @@
use HTMLFormElement;
public function __construct( $fieldWidget, array $config = [] ) {
- // Parent constructor
parent::__construct( $fieldWidget, $config );
+
// Traits
$this->initializeHTMLFormElement( $config );
}
@@ -53,8 +53,8 @@
use HTMLFormElement;
public function __construct( $fieldWidget, $buttonWidget = false, array $config = [] ) {
- // Parent constructor
parent::__construct( $fieldWidget, $buttonWidget, $config );
+
// Traits
$this->initializeHTMLFormElement( $config );
}
diff --git a/includes/libs/CSSMin.php b/includes/libs/CSSMin.php
index ee88d0d..a9cbba2 100644
--- a/includes/libs/CSSMin.php
+++ b/includes/libs/CSSMin.php
@@ -29,8 +29,6 @@
*/
class CSSMin {
- /* Constants */
-
/** @var string Strip marker for comments. **/
const PLACEHOLDER = "\x7fPLACEHOLDER\x7f";
@@ -41,8 +39,6 @@
const EMBED_REGEX = '\/\*\s*\@embed\s*\*\/';
const COMMENT_REGEX = '\/\*.*?\*\/';
-
- /* Protected Static Members */
/** @var array List of common image files extensions and MIME-types */
protected static $mimeTypes = [
@@ -56,8 +52,6 @@
'xbm' => 'image/x-xbitmap',
'svg' => 'image/svg+xml',
];
-
- /* Static Methods */
/**
* Get a list of local files referenced in a stylesheet (includes non-existent files).
diff --git a/includes/libs/JavaScriptMinifier.php b/includes/libs/JavaScriptMinifier.php
index bbba33a..ea4755e 100644
--- a/includes/libs/JavaScriptMinifier.php
+++ b/includes/libs/JavaScriptMinifier.php
@@ -18,7 +18,6 @@
*/
class JavaScriptMinifier {
- /* Class constants */
/* Parsing states.
* The state machine is only necessary to decide whether to parse a slash as division
* operator or as regexp literal.
@@ -63,8 +62,6 @@
// Sanity limit to avoid excessive memory usage
const STACK_LIMIT = 1000;
-
- /* Static functions */
/**
* Returns minified JavaScript code.
diff --git a/includes/resourceloader/ResourceLoader.php b/includes/resourceloader/ResourceLoader.php
index b2e1c49..63a495a 100644
--- a/includes/resourceloader/ResourceLoader.php
+++ b/includes/resourceloader/ResourceLoader.php
@@ -236,8 +236,6 @@
return $data;
}
- /* Methods */
-
/**
* Register core modules and runs registration hooks.
* @param Config $config [optional]
@@ -1209,8 +1207,6 @@
}
return $moduleNames;
}
-
- /* Static Methods */
/**
* Return JS code that calls mw.loader.implement with given module properties.
diff --git a/includes/resourceloader/ResourceLoaderFileModule.php b/includes/resourceloader/ResourceLoaderFileModule.php
index 4675191..f2f3383 100644
--- a/includes/resourceloader/ResourceLoaderFileModule.php
+++ b/includes/resourceloader/ResourceLoaderFileModule.php
@@ -26,7 +26,6 @@
* ResourceLoader module based on local JavaScript/CSS files.
*/
class ResourceLoaderFileModule extends ResourceLoaderModule {
- /* Protected Members */
/** @var string Local base path, see __construct() */
protected $localBasePath = '';
@@ -148,8 +147,6 @@
* Used in tests to detect missing dependencies.
*/
protected $missingLocalFileRefs = [];
-
- /* Methods */
/**
* Constructs a new module from an options array.
diff --git a/includes/resourceloader/ResourceLoaderFilePath.php b/includes/resourceloader/ResourceLoaderFilePath.php
index dd239d0..3cf09d8 100644
--- a/includes/resourceloader/ResourceLoaderFilePath.php
+++ b/includes/resourceloader/ResourceLoaderFilePath.php
@@ -26,7 +26,6 @@
* and local base path, for use with ResourceLoaderFileModule.
*/
class ResourceLoaderFilePath {
- /* Protected Members */
/** @var string Local base path */
protected $localBasePath;
@@ -37,8 +36,6 @@
/**
* @var string Path to the file */
protected $path;
-
- /* Methods */
/**
* @param string $path Path to the file.
diff --git a/includes/resourceloader/ResourceLoaderModule.php b/includes/resourceloader/ResourceLoaderModule.php
index b3c1cd1..0104ec3 100644
--- a/includes/resourceloader/ResourceLoaderModule.php
+++ b/includes/resourceloader/ResourceLoaderModule.php
@@ -65,8 +65,6 @@
# pages like Special:UserLogin and Special:Preferences
protected $origin = self::ORIGIN_CORE_SITEWIDE;
- /* Protected Members */
-
protected $name = null;
protected $targets = [ 'desktop' ];
@@ -93,8 +91,6 @@
* @var LoggerInterface
*/
protected $logger;
-
- /* Methods */
/**
* Get this module's name. This is set when the module is registered
diff --git a/includes/resourceloader/ResourceLoaderUserTokensModule.php b/includes/resourceloader/ResourceLoaderUserTokensModule.php
index bfa7326..e933f1f 100644
--- a/includes/resourceloader/ResourceLoaderUserTokensModule.php
+++ b/includes/resourceloader/ResourceLoaderUserTokensModule.php
@@ -26,13 +26,9 @@
*/
class ResourceLoaderUserTokensModule extends ResourceLoaderModule {
- /* Protected Members */
-
protected $origin = self::ORIGIN_CORE_INDIVIDUAL;
protected $targets = [ 'desktop', 'mobile' ];
-
- /* Methods */
/**
* Fetch the tokens for the current user.
diff --git a/includes/specials/pagers/ProtectedPagesPager.php b/includes/specials/pagers/ProtectedPagesPager.php
index 1587abc..af04703 100644
--- a/includes/specials/pagers/ProtectedPagesPager.php
+++ b/includes/specials/pagers/ProtectedPagesPager.php
@@ -19,12 +19,10 @@
* @ingroup Pager
*/
-use \MediaWiki\Linker\LinkRenderer;
+use MediaWiki\Linker\LinkRenderer;
-/**
- * @todo document
- */
class ProtectedPagesPager extends TablePager {
+
public $mForm, $mConds;
private $type, $level, $namespace, $sizetype, $size, $indefonly, $cascadeonly, $noredirect;
diff --git a/includes/widget/ComplexNamespaceInputWidget.php b/includes/widget/ComplexNamespaceInputWidget.php
index d3ada03..1d83f51 100644
--- a/includes/widget/ComplexNamespaceInputWidget.php
+++ b/includes/widget/ComplexNamespaceInputWidget.php
@@ -51,7 +51,6 @@
$config
);
- // Parent constructor
parent::__construct( $config );
// Properties
diff --git a/includes/widget/ComplexTitleInputWidget.php b/includes/widget/ComplexTitleInputWidget.php
index a9e8042..912537a 100644
--- a/includes/widget/ComplexTitleInputWidget.php
+++ b/includes/widget/ComplexTitleInputWidget.php
@@ -33,7 +33,6 @@
$config
);
- // Parent constructor
parent::__construct( $config );
// Properties
diff --git a/includes/widget/DateInputWidget.php b/includes/widget/DateInputWidget.php
index 507dab6..b516331 100644
--- a/includes/widget/DateInputWidget.php
+++ b/includes/widget/DateInputWidget.php
@@ -109,7 +109,6 @@
'placeholder' => $placeholder,
], $config );
- // Parent constructor
parent::__construct( $config );
// Calculate min/max attributes (which are skipped by TextInputWidget) and add to <input>
diff --git a/includes/widget/DateTimeInputWidget.php b/includes/widget/DateTimeInputWidget.php
index f0d5cdb..4c41212 100644
--- a/includes/widget/DateTimeInputWidget.php
+++ b/includes/widget/DateTimeInputWidget.php
@@ -34,7 +34,6 @@
throw new \InvalidArgumentException( '$config[\'type\'] must be specified' );
}
- // Parent constructor
parent::__construct( $config );
// Properties, which are ignored in PHP and just shipped back to JS
diff --git a/includes/widget/NamespaceInputWidget.php b/includes/widget/NamespaceInputWidget.php
index 3e913b0..5fdc710 100644
--- a/includes/widget/NamespaceInputWidget.php
+++ b/includes/widget/NamespaceInputWidget.php
@@ -24,7 +24,6 @@
// Configuration initialization
$config['options'] = $this->getNamespaceDropdownOptions( $config );
- // Parent constructor
parent::__construct( $config );
// Properties
diff --git a/includes/widget/SearchInputWidget.php b/includes/widget/SearchInputWidget.php
index 773c291..70b0dcc 100644
--- a/includes/widget/SearchInputWidget.php
+++ b/includes/widget/SearchInputWidget.php
@@ -34,7 +34,6 @@
'icon' => 'search',
], $config );
- // Parent constructor
parent::__construct( $config );
// Properties, which are ignored in PHP and just shipped back to JS
diff --git a/includes/widget/SelectWithInputWidget.php b/includes/widget/SelectWithInputWidget.php
index d2dda75..3abfbd0 100644
--- a/includes/widget/SelectWithInputWidget.php
+++ b/includes/widget/SelectWithInputWidget.php
@@ -38,7 +38,6 @@
$config
);
- // Parent constructor
parent::__construct( $config );
// Properties
diff --git a/includes/widget/TitleInputWidget.php b/includes/widget/TitleInputWidget.php
index da2e94b..a29c3dc 100644
--- a/includes/widget/TitleInputWidget.php
+++ b/includes/widget/TitleInputWidget.php
@@ -30,7 +30,6 @@
* be a valid title (default: true)
*/
public function __construct( array $config = [] ) {
- // Parent constructor
parent::__construct(
array_merge( [ 'maxLength' => 255 ], $config )
);
diff --git a/includes/widget/UserInputWidget.php b/includes/widget/UserInputWidget.php
index d591ad1..a058ab6 100644
--- a/includes/widget/UserInputWidget.php
+++ b/includes/widget/UserInputWidget.php
@@ -16,7 +16,6 @@
* @param array $config Configuration options
*/
public function __construct( array $config = [] ) {
- // Parent constructor
parent::__construct( $config );
// Initialization
--
To view, visit https://gerrit.wikimedia.org/r/400583
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7458e714976a6acd3ba6a7c93fdc27d03903df83
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Thiemo Kreuz (WMDE) <***@wikimedia.de>
Change subject: Remove self-explaining "section heading" comments from classes
......................................................................
Remove self-explaining "section heading" comments from classes
I can see that "parent::__construct" literally calls the parent
constructor. I can see that stuff preceeded by the keyword "protected"
is protected. I really (really) don't need comments explaining such.
Change-Id: I7458e714976a6acd3ba6a7c93fdc27d03903df83
---
M includes/Linker.php
M includes/actions/WatchAction.php
M includes/context/RequestContext.php
M includes/htmlform/HTMLFormElement.php
M includes/libs/CSSMin.php
M includes/libs/JavaScriptMinifier.php
M includes/resourceloader/ResourceLoader.php
M includes/resourceloader/ResourceLoaderFileModule.php
M includes/resourceloader/ResourceLoaderFilePath.php
M includes/resourceloader/ResourceLoaderModule.php
M includes/resourceloader/ResourceLoaderUserTokensModule.php
M includes/specials/pagers/ProtectedPagesPager.php
M includes/widget/ComplexNamespaceInputWidget.php
M includes/widget/ComplexTitleInputWidget.php
M includes/widget/DateInputWidget.php
M includes/widget/DateTimeInputWidget.php
M includes/widget/NamespaceInputWidget.php
M includes/widget/SearchInputWidget.php
M includes/widget/SelectWithInputWidget.php
M includes/widget/TitleInputWidget.php
M includes/widget/UserInputWidget.php
21 files changed, 4 insertions(+), 50 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/83/400583/1
diff --git a/includes/Linker.php b/includes/Linker.php
index 84e3103..c0255ac 100644
--- a/includes/Linker.php
+++ b/includes/Linker.php
@@ -2124,8 +2124,6 @@
return Xml::tags( 'span', [ 'class' => 'mw-revdelundel-link' ], $htmlParentheses );
}
- /* Deprecated methods */
-
/**
* Returns the attributes for the tooltip and access key.
*
diff --git a/includes/actions/WatchAction.php b/includes/actions/WatchAction.php
index e12a727..528e0e2 100644
--- a/includes/actions/WatchAction.php
+++ b/includes/actions/WatchAction.php
@@ -80,8 +80,6 @@
$this->getOutput()->addWikiMsg( $msgKey, $this->getTitle()->getPrefixedText() );
}
- /* Static utility methods */
-
/**
* Watch or unwatch a page
* @since 1.22
diff --git a/includes/context/RequestContext.php b/includes/context/RequestContext.php
index c2d0de1..652f068 100644
--- a/includes/context/RequestContext.php
+++ b/includes/context/RequestContext.php
@@ -441,8 +441,6 @@
return $this->skin;
}
- /** Helpful methods **/
-
/**
* Get a Message object with context set
* Parameters are the same as wfMessage()
@@ -457,8 +455,6 @@
return call_user_func_array( 'wfMessage', $args )->setContext( $this );
}
-
- /** Static methods **/
/**
* Get the RequestContext object associated with the main request
diff --git a/includes/htmlform/HTMLFormElement.php b/includes/htmlform/HTMLFormElement.php
index 10db90c..66d6143 100644
--- a/includes/htmlform/HTMLFormElement.php
+++ b/includes/htmlform/HTMLFormElement.php
@@ -38,8 +38,8 @@
use HTMLFormElement;
public function __construct( $fieldWidget, array $config = [] ) {
- // Parent constructor
parent::__construct( $fieldWidget, $config );
+
// Traits
$this->initializeHTMLFormElement( $config );
}
@@ -53,8 +53,8 @@
use HTMLFormElement;
public function __construct( $fieldWidget, $buttonWidget = false, array $config = [] ) {
- // Parent constructor
parent::__construct( $fieldWidget, $buttonWidget, $config );
+
// Traits
$this->initializeHTMLFormElement( $config );
}
diff --git a/includes/libs/CSSMin.php b/includes/libs/CSSMin.php
index ee88d0d..a9cbba2 100644
--- a/includes/libs/CSSMin.php
+++ b/includes/libs/CSSMin.php
@@ -29,8 +29,6 @@
*/
class CSSMin {
- /* Constants */
-
/** @var string Strip marker for comments. **/
const PLACEHOLDER = "\x7fPLACEHOLDER\x7f";
@@ -41,8 +39,6 @@
const EMBED_REGEX = '\/\*\s*\@embed\s*\*\/';
const COMMENT_REGEX = '\/\*.*?\*\/';
-
- /* Protected Static Members */
/** @var array List of common image files extensions and MIME-types */
protected static $mimeTypes = [
@@ -56,8 +52,6 @@
'xbm' => 'image/x-xbitmap',
'svg' => 'image/svg+xml',
];
-
- /* Static Methods */
/**
* Get a list of local files referenced in a stylesheet (includes non-existent files).
diff --git a/includes/libs/JavaScriptMinifier.php b/includes/libs/JavaScriptMinifier.php
index bbba33a..ea4755e 100644
--- a/includes/libs/JavaScriptMinifier.php
+++ b/includes/libs/JavaScriptMinifier.php
@@ -18,7 +18,6 @@
*/
class JavaScriptMinifier {
- /* Class constants */
/* Parsing states.
* The state machine is only necessary to decide whether to parse a slash as division
* operator or as regexp literal.
@@ -63,8 +62,6 @@
// Sanity limit to avoid excessive memory usage
const STACK_LIMIT = 1000;
-
- /* Static functions */
/**
* Returns minified JavaScript code.
diff --git a/includes/resourceloader/ResourceLoader.php b/includes/resourceloader/ResourceLoader.php
index b2e1c49..63a495a 100644
--- a/includes/resourceloader/ResourceLoader.php
+++ b/includes/resourceloader/ResourceLoader.php
@@ -236,8 +236,6 @@
return $data;
}
- /* Methods */
-
/**
* Register core modules and runs registration hooks.
* @param Config $config [optional]
@@ -1209,8 +1207,6 @@
}
return $moduleNames;
}
-
- /* Static Methods */
/**
* Return JS code that calls mw.loader.implement with given module properties.
diff --git a/includes/resourceloader/ResourceLoaderFileModule.php b/includes/resourceloader/ResourceLoaderFileModule.php
index 4675191..f2f3383 100644
--- a/includes/resourceloader/ResourceLoaderFileModule.php
+++ b/includes/resourceloader/ResourceLoaderFileModule.php
@@ -26,7 +26,6 @@
* ResourceLoader module based on local JavaScript/CSS files.
*/
class ResourceLoaderFileModule extends ResourceLoaderModule {
- /* Protected Members */
/** @var string Local base path, see __construct() */
protected $localBasePath = '';
@@ -148,8 +147,6 @@
* Used in tests to detect missing dependencies.
*/
protected $missingLocalFileRefs = [];
-
- /* Methods */
/**
* Constructs a new module from an options array.
diff --git a/includes/resourceloader/ResourceLoaderFilePath.php b/includes/resourceloader/ResourceLoaderFilePath.php
index dd239d0..3cf09d8 100644
--- a/includes/resourceloader/ResourceLoaderFilePath.php
+++ b/includes/resourceloader/ResourceLoaderFilePath.php
@@ -26,7 +26,6 @@
* and local base path, for use with ResourceLoaderFileModule.
*/
class ResourceLoaderFilePath {
- /* Protected Members */
/** @var string Local base path */
protected $localBasePath;
@@ -37,8 +36,6 @@
/**
* @var string Path to the file */
protected $path;
-
- /* Methods */
/**
* @param string $path Path to the file.
diff --git a/includes/resourceloader/ResourceLoaderModule.php b/includes/resourceloader/ResourceLoaderModule.php
index b3c1cd1..0104ec3 100644
--- a/includes/resourceloader/ResourceLoaderModule.php
+++ b/includes/resourceloader/ResourceLoaderModule.php
@@ -65,8 +65,6 @@
# pages like Special:UserLogin and Special:Preferences
protected $origin = self::ORIGIN_CORE_SITEWIDE;
- /* Protected Members */
-
protected $name = null;
protected $targets = [ 'desktop' ];
@@ -93,8 +91,6 @@
* @var LoggerInterface
*/
protected $logger;
-
- /* Methods */
/**
* Get this module's name. This is set when the module is registered
diff --git a/includes/resourceloader/ResourceLoaderUserTokensModule.php b/includes/resourceloader/ResourceLoaderUserTokensModule.php
index bfa7326..e933f1f 100644
--- a/includes/resourceloader/ResourceLoaderUserTokensModule.php
+++ b/includes/resourceloader/ResourceLoaderUserTokensModule.php
@@ -26,13 +26,9 @@
*/
class ResourceLoaderUserTokensModule extends ResourceLoaderModule {
- /* Protected Members */
-
protected $origin = self::ORIGIN_CORE_INDIVIDUAL;
protected $targets = [ 'desktop', 'mobile' ];
-
- /* Methods */
/**
* Fetch the tokens for the current user.
diff --git a/includes/specials/pagers/ProtectedPagesPager.php b/includes/specials/pagers/ProtectedPagesPager.php
index 1587abc..af04703 100644
--- a/includes/specials/pagers/ProtectedPagesPager.php
+++ b/includes/specials/pagers/ProtectedPagesPager.php
@@ -19,12 +19,10 @@
* @ingroup Pager
*/
-use \MediaWiki\Linker\LinkRenderer;
+use MediaWiki\Linker\LinkRenderer;
-/**
- * @todo document
- */
class ProtectedPagesPager extends TablePager {
+
public $mForm, $mConds;
private $type, $level, $namespace, $sizetype, $size, $indefonly, $cascadeonly, $noredirect;
diff --git a/includes/widget/ComplexNamespaceInputWidget.php b/includes/widget/ComplexNamespaceInputWidget.php
index d3ada03..1d83f51 100644
--- a/includes/widget/ComplexNamespaceInputWidget.php
+++ b/includes/widget/ComplexNamespaceInputWidget.php
@@ -51,7 +51,6 @@
$config
);
- // Parent constructor
parent::__construct( $config );
// Properties
diff --git a/includes/widget/ComplexTitleInputWidget.php b/includes/widget/ComplexTitleInputWidget.php
index a9e8042..912537a 100644
--- a/includes/widget/ComplexTitleInputWidget.php
+++ b/includes/widget/ComplexTitleInputWidget.php
@@ -33,7 +33,6 @@
$config
);
- // Parent constructor
parent::__construct( $config );
// Properties
diff --git a/includes/widget/DateInputWidget.php b/includes/widget/DateInputWidget.php
index 507dab6..b516331 100644
--- a/includes/widget/DateInputWidget.php
+++ b/includes/widget/DateInputWidget.php
@@ -109,7 +109,6 @@
'placeholder' => $placeholder,
], $config );
- // Parent constructor
parent::__construct( $config );
// Calculate min/max attributes (which are skipped by TextInputWidget) and add to <input>
diff --git a/includes/widget/DateTimeInputWidget.php b/includes/widget/DateTimeInputWidget.php
index f0d5cdb..4c41212 100644
--- a/includes/widget/DateTimeInputWidget.php
+++ b/includes/widget/DateTimeInputWidget.php
@@ -34,7 +34,6 @@
throw new \InvalidArgumentException( '$config[\'type\'] must be specified' );
}
- // Parent constructor
parent::__construct( $config );
// Properties, which are ignored in PHP and just shipped back to JS
diff --git a/includes/widget/NamespaceInputWidget.php b/includes/widget/NamespaceInputWidget.php
index 3e913b0..5fdc710 100644
--- a/includes/widget/NamespaceInputWidget.php
+++ b/includes/widget/NamespaceInputWidget.php
@@ -24,7 +24,6 @@
// Configuration initialization
$config['options'] = $this->getNamespaceDropdownOptions( $config );
- // Parent constructor
parent::__construct( $config );
// Properties
diff --git a/includes/widget/SearchInputWidget.php b/includes/widget/SearchInputWidget.php
index 773c291..70b0dcc 100644
--- a/includes/widget/SearchInputWidget.php
+++ b/includes/widget/SearchInputWidget.php
@@ -34,7 +34,6 @@
'icon' => 'search',
], $config );
- // Parent constructor
parent::__construct( $config );
// Properties, which are ignored in PHP and just shipped back to JS
diff --git a/includes/widget/SelectWithInputWidget.php b/includes/widget/SelectWithInputWidget.php
index d2dda75..3abfbd0 100644
--- a/includes/widget/SelectWithInputWidget.php
+++ b/includes/widget/SelectWithInputWidget.php
@@ -38,7 +38,6 @@
$config
);
- // Parent constructor
parent::__construct( $config );
// Properties
diff --git a/includes/widget/TitleInputWidget.php b/includes/widget/TitleInputWidget.php
index da2e94b..a29c3dc 100644
--- a/includes/widget/TitleInputWidget.php
+++ b/includes/widget/TitleInputWidget.php
@@ -30,7 +30,6 @@
* be a valid title (default: true)
*/
public function __construct( array $config = [] ) {
- // Parent constructor
parent::__construct(
array_merge( [ 'maxLength' => 255 ], $config )
);
diff --git a/includes/widget/UserInputWidget.php b/includes/widget/UserInputWidget.php
index d591ad1..a058ab6 100644
--- a/includes/widget/UserInputWidget.php
+++ b/includes/widget/UserInputWidget.php
@@ -16,7 +16,6 @@
* @param array $config Configuration options
*/
public function __construct( array $config = [] ) {
- // Parent constructor
parent::__construct( $config );
// Initialization
--
To view, visit https://gerrit.wikimedia.org/r/400583
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7458e714976a6acd3ba6a7c93fdc27d03903df83
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Thiemo Kreuz (WMDE) <***@wikimedia.de>