Discussion:
[MediaWiki-commits] [Gerrit] mediawiki...SocialProfile[master]: Use relative path in require_once
Umherirrender (Code Review)
2017-12-30 21:56:37 UTC
Permalink
Umherirrender has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401098 )

Change subject: Use relative path in require_once
......................................................................

Use relative path in require_once

No need for absolute path with $IP
There is no need to install SocialProfile inside a folder called
extensions

Change-Id: I903ce4a3f1a1716e72c8ccec8419bb22d51f1798
---
M SocialProfile.php
1 file changed, 1 insertion(+), 1 deletion(-)


git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SocialProfile refs/changes/98/401098/1

diff --git a/SocialProfile.php b/SocialProfile.php
index 92d2498..5046af6 100644
--- a/SocialProfile.php
+++ b/SocialProfile.php
@@ -94,7 +94,7 @@
$wgAutoloadClasses['SocialProfileHooks'] = __DIR__ . '/SocialProfileHooks.php';

// Loader files
-require_once( "$IP/extensions/SocialProfile/UserProfile/UserProfile.php" ); // Profile page configuration loader file
+require_once __DIR__ . '/UserProfile/UserProfile.php'; // Profile page configuration loader file
wfLoadExtensions( [
'SocialProfile/SystemGifts', // SystemGifts (awards functionality)
'SocialProfile/UserActivity', // UserActivity - recent social changes
--
To view, visit https://gerrit.wikimedia.org/r/401098
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I903ce4a3f1a1716e72c8ccec8419bb22d51f1798
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SocialProfile
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <***@web.de>
jenkins-bot (Code Review)
2017-12-30 23:31:46 UTC
Permalink
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/401098 )

Change subject: Use relative path in require_once
......................................................................


Use relative path in require_once

No need for absolute path with $IP
There is no need to install SocialProfile inside a folder called
extensions

Change-Id: I903ce4a3f1a1716e72c8ccec8419bb22d51f1798
---
M SocialProfile.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
SamanthaNguyen: Looks good to me, approved
jenkins-bot: Verified



diff --git a/SocialProfile.php b/SocialProfile.php
index 92d2498..5046af6 100644
--- a/SocialProfile.php
+++ b/SocialProfile.php
@@ -94,7 +94,7 @@
$wgAutoloadClasses['SocialProfileHooks'] = __DIR__ . '/SocialProfileHooks.php';

// Loader files
-require_once( "$IP/extensions/SocialProfile/UserProfile/UserProfile.php" ); // Profile page configuration loader file
+require_once __DIR__ . '/UserProfile/UserProfile.php'; // Profile page configuration loader file
wfLoadExtensions( [
'SocialProfile/SystemGifts', // SystemGifts (awards functionality)
'SocialProfile/UserActivity', // UserActivity - recent social changes
--
To view, visit https://gerrit.wikimedia.org/r/401098
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I903ce4a3f1a1716e72c8ccec8419bb22d51f1798
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SocialProfile
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <***@web.de>
Gerrit-Reviewer: Lewis Cawte <***@lewiscawte.me>
Gerrit-Reviewer: SamanthaNguyen <***@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
Loading...