Umherirrender (Code Review)
2017-12-31 11:39:11 UTC
Umherirrender has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401166 )
Change subject: Add php-parallel-lint, grunt-jsonlint and grunt-banana-checker
......................................................................
Add php-parallel-lint, grunt-jsonlint and grunt-banana-checker
jsonlint and banana-checker will test for valid i18n files
php-lint will test for valid php files
Change-Id: Ib3a57a12d49a62031ef3e3255d2663c8c0d73e33
---
A Gruntfile.js
M composer.json
A package.json
3 files changed, 39 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceInsertMagic refs/changes/66/401166/1
diff --git a/Gruntfile.js b/Gruntfile.js
new file mode 100644
index 0000000..ea67e84
--- /dev/null
+++ b/Gruntfile.js
@@ -0,0 +1,19 @@
+module.exports = function ( grunt ) {
+ grunt.loadNpmTasks( 'grunt-jsonlint' );
+ grunt.loadNpmTasks( 'grunt-banana-checker' );
+
+ var conf = grunt.file.readJSON( 'extension.json' );
+ grunt.initConfig( {
+ banana: conf.MessagesDirs,
+ jsonlint: {
+ all: [
+ '**/*.json',
+ '!node_modules/**',
+ '!vendor/**'
+ ]
+ }
+ } );
+
+ grunt.registerTask( 'test', [ 'jsonlint', 'banana' ] );
+ grunt.registerTask( 'default', 'test' );
+};
diff --git a/composer.json b/composer.json
index 018bf12..caab47a 100644
--- a/composer.json
+++ b/composer.json
@@ -6,6 +6,15 @@
"require": {
"composer/installers": "~1.0"
},
+ "require-dev": {
+ "jakub-onderka/php-parallel-lint": "0.9.2",
+ "jakub-onderka/php-console-highlighter": "0.3.2"
+ },
+ "scripts": {
+ "test": [
+ "parallel-lint . --exclude vendor --exclude node_modules"
+ ]
+ },
"autoload": {
"psr-4": {
}
diff --git a/package.json b/package.json
new file mode 100644
index 0000000..10fa9bc
--- /dev/null
+++ b/package.json
@@ -0,0 +1,11 @@
+{
+ "private": true,
+ "scripts": {
+ "test": "grunt test"
+ },
+ "devDependencies": {
+ "grunt": "1.0.1",
+ "grunt-banana-checker": "0.6.0",
+ "grunt-jsonlint": "1.1.0"
+ }
+}
--
To view, visit https://gerrit.wikimedia.org/r/401166
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib3a57a12d49a62031ef3e3255d2663c8c0d73e33
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceInsertMagic
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <***@web.de>
Change subject: Add php-parallel-lint, grunt-jsonlint and grunt-banana-checker
......................................................................
Add php-parallel-lint, grunt-jsonlint and grunt-banana-checker
jsonlint and banana-checker will test for valid i18n files
php-lint will test for valid php files
Change-Id: Ib3a57a12d49a62031ef3e3255d2663c8c0d73e33
---
A Gruntfile.js
M composer.json
A package.json
3 files changed, 39 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceInsertMagic refs/changes/66/401166/1
diff --git a/Gruntfile.js b/Gruntfile.js
new file mode 100644
index 0000000..ea67e84
--- /dev/null
+++ b/Gruntfile.js
@@ -0,0 +1,19 @@
+module.exports = function ( grunt ) {
+ grunt.loadNpmTasks( 'grunt-jsonlint' );
+ grunt.loadNpmTasks( 'grunt-banana-checker' );
+
+ var conf = grunt.file.readJSON( 'extension.json' );
+ grunt.initConfig( {
+ banana: conf.MessagesDirs,
+ jsonlint: {
+ all: [
+ '**/*.json',
+ '!node_modules/**',
+ '!vendor/**'
+ ]
+ }
+ } );
+
+ grunt.registerTask( 'test', [ 'jsonlint', 'banana' ] );
+ grunt.registerTask( 'default', 'test' );
+};
diff --git a/composer.json b/composer.json
index 018bf12..caab47a 100644
--- a/composer.json
+++ b/composer.json
@@ -6,6 +6,15 @@
"require": {
"composer/installers": "~1.0"
},
+ "require-dev": {
+ "jakub-onderka/php-parallel-lint": "0.9.2",
+ "jakub-onderka/php-console-highlighter": "0.3.2"
+ },
+ "scripts": {
+ "test": [
+ "parallel-lint . --exclude vendor --exclude node_modules"
+ ]
+ },
"autoload": {
"psr-4": {
}
diff --git a/package.json b/package.json
new file mode 100644
index 0000000..10fa9bc
--- /dev/null
+++ b/package.json
@@ -0,0 +1,11 @@
+{
+ "private": true,
+ "scripts": {
+ "test": "grunt test"
+ },
+ "devDependencies": {
+ "grunt": "1.0.1",
+ "grunt-banana-checker": "0.6.0",
+ "grunt-jsonlint": "1.1.0"
+ }
+}
--
To view, visit https://gerrit.wikimedia.org/r/401166
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib3a57a12d49a62031ef3e3255d2663c8c0d73e33
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceInsertMagic
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <***@web.de>