[MediaWiki-commits] [Gerrit] mediawiki...ApiFeatureUsage[master]: Add missing visibility declarations

[Anomie (Code Review)]

Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401088 )

Change subject: Add missing visibility declarations
......................................................................

Add missing visibility declarations

And re-enable Squiz.Scope.MethodScope.Missing

Change-Id: Ied209262eb592f80fe37b4ba684cf5844d7808d9
---
M .phpcs.xml
M ApiQueryFeatureUsage.php
M SpecialApiFeatureUsage.php
3 files changed, 3 insertions(+), 4 deletions(-)


git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ApiFeatureUsage refs/changes/88/401088/1

diff --git a/.phpcs.xml b/.phpcs.xml
index 28c8136..d87bc24 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -6,7 +6,6 @@
<exclude name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
<exclude name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
<exclude name="MediaWiki.Files.ClassMatchesFilename.NotMatch" />
- <exclude name="Squiz.Scope.MethodScope.Missing" />
</rule>
<file>.</file>
<arg name="extensions" value="php,php5,inc"/>
diff --git a/ApiQueryFeatureUsage.php b/ApiQueryFeatureUsage.php
index a3a32c6..edbac7e 100644
--- a/ApiQueryFeatureUsage.php
+++ b/ApiQueryFeatureUsage.php
@@ -5,7 +5,7 @@
parent::__construct( $query, $moduleName, 'afu' );
}

- function execute() {
+ public function execute() {
$params = $this->extractRequestParams();

$agent = $params['agent'] === null
diff --git a/SpecialApiFeatureUsage.php b/SpecialApiFeatureUsage.php
index d965053..28f11b9 100644
--- a/SpecialApiFeatureUsage.php
+++ b/SpecialApiFeatureUsage.php
@@ -2,11 +2,11 @@
class SpecialApiFeatureUsage extends SpecialPage {
private $engine = null;

- function __construct() {
+ public function __construct() {
parent::__construct( 'ApiFeatureUsage' );
}

- function execute( $par ) {
+ public function execute( $par ) {
$this->setHeaders();
$this->checkPermissions();
--
To view, visit https://gerrit.wikimedia.org/r/401088
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ied209262eb592f80fe37b4ba684cf5844d7808d9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ApiFeatureUsage
Gerrit-Branch: master
Gerrit-Owner: Anomie <***@wikimedia.org>

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/401088 )

Change subject: Add missing visibility declarations
......................................................................


Add missing visibility declarations

And re-enable Squiz.Scope.MethodScope.Missing

Change-Id: Ied209262eb592f80fe37b4ba684cf5844d7808d9
---
M .phpcs.xml
M ApiQueryFeatureUsage.php
M SpecialApiFeatureUsage.php
3 files changed, 3 insertions(+), 4 deletions(-)

Approvals:
Umherirrender: Looks good to me, approved
jenkins-bot: Verified



diff --git a/.phpcs.xml b/.phpcs.xml
index 28c8136..d87bc24 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -6,7 +6,6 @@
<exclude name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
<exclude name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
<exclude name="MediaWiki.Files.ClassMatchesFilename.NotMatch" />
- <exclude name="Squiz.Scope.MethodScope.Missing" />
</rule>
<file>.</file>
<arg name="extensions" value="php,php5,inc"/>
diff --git a/ApiQueryFeatureUsage.php b/ApiQueryFeatureUsage.php
index a3a32c6..edbac7e 100644
--- a/ApiQueryFeatureUsage.php
+++ b/ApiQueryFeatureUsage.php
@@ -5,7 +5,7 @@
parent::__construct( $query, $moduleName, 'afu' );
}

- function execute() {
+ public function execute() {
$params = $this->extractRequestParams();

$agent = $params['agent'] === null
diff --git a/SpecialApiFeatureUsage.php b/SpecialApiFeatureUsage.php
index d965053..28f11b9 100644
--- a/SpecialApiFeatureUsage.php
+++ b/SpecialApiFeatureUsage.php
@@ -2,11 +2,11 @@
class SpecialApiFeatureUsage extends SpecialPage {
private $engine = null;

- function __construct() {
+ public function __construct() {
parent::__construct( 'ApiFeatureUsage' );
}

- function execute( $par ) {
+ public function execute( $par ) {
$this->setHeaders();
$this->checkPermissions();
--
To view, visit https://gerrit.wikimedia.org/r/401088
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ied209262eb592f80fe37b4ba684cf5844d7808d9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ApiFeatureUsage
Gerrit-Branch: master
Gerrit-Owner: Anomie <***@wikimedia.org>
Gerrit-Reviewer: Legoktm <***@member.fsf.org>
Gerrit-Reviewer: Umherirrender <***@web.de>
Gerrit-Reviewer: jenkins-bot <>