[MediaWiki-commits] [Gerrit] mediawiki...Truglass[master]: Avoid PHP 7.1 warning of &$this usage

[LukBukkit (Code Review)]

LukBukkit has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401096 )

Change subject: Avoid PHP 7.1 warning of &$this usage
......................................................................

Avoid PHP 7.1 warning of &$this usage

Bug: T153505
Change-Id: Ic9834566e1346fbc91e44ed9fab8a694b2763a25
---
M includes/TruglassTemplate.php
1 file changed, 3 insertions(+), 1 deletion(-)


git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Truglass refs/changes/96/401096/1

diff --git a/includes/TruglassTemplate.php b/includes/TruglassTemplate.php
index 7c9b9a5..a9b534a 100644
--- a/includes/TruglassTemplate.php
+++ b/includes/TruglassTemplate.php
@@ -284,7 +284,9 @@
echo $this->makeListItem( $key, $tbitem );
}

- Hooks::run( 'SkinTemplateToolboxEnd', array( &$this, true ) );
+ // Avoid PHP 7.1 warning of passing $this by reference
+ $template = $this;
+ Hooks::run( 'SkinTemplateToolboxEnd', array( &$template, true ) );
?>
</ul>
</div>
--
To view, visit https://gerrit.wikimedia.org/r/401096
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic9834566e1346fbc91e44ed9fab8a694b2763a25
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Truglass
Gerrit-Branch: master
Gerrit-Owner: LukBukkit <***@gmail.com>

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/401096 )

Change subject: Avoid PHP 7.1 warning of &$this usage
......................................................................


Avoid PHP 7.1 warning of &$this usage

Bug: T153505
Change-Id: Ic9834566e1346fbc91e44ed9fab8a694b2763a25
---
M includes/TruglassTemplate.php
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
Florianschmidtwelzow: Looks good to me, approved
jenkins-bot: Verified



diff --git a/includes/TruglassTemplate.php b/includes/TruglassTemplate.php
index 7c9b9a5..a9b534a 100644
--- a/includes/TruglassTemplate.php
+++ b/includes/TruglassTemplate.php
@@ -284,7 +284,9 @@
echo $this->makeListItem( $key, $tbitem );
}

- Hooks::run( 'SkinTemplateToolboxEnd', array( &$this, true ) );
+ // Avoid PHP 7.1 warning of passing $this by reference
+ $template = $this;
+ Hooks::run( 'SkinTemplateToolboxEnd', array( &$template, true ) );
?>
</ul>
</div>
--
To view, visit https://gerrit.wikimedia.org/r/401096
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9834566e1346fbc91e44ed9fab8a694b2763a25
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Truglass
Gerrit-Branch: master
Gerrit-Owner: LukBukkit <***@gmail.com>
Gerrit-Reviewer: Florianschmidtwelzow <***@gmail.com>
Gerrit-Reviewer: jenkins-bot <>