SamanthaNguyen (Code Review)
2017-12-31 23:52:49 UTC
SamanthaNguyen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401195 )
Change subject: UserBoard i18n: Fix phrasing of Echo notification bundle message
......................................................................
UserBoard i18n: Fix phrasing of Echo notification bundle message
This message has been phrased incorrectly, as it wrongly assumes
that each message is sent by a different person. The easiest way to
"fix" this error is to rephrase this message.
- New: "{{PLURAL:$1|One message|$1
messages|100=99+ messages}} have been left on your user board."
- Original: "{{PLURAL:$1|One person|$1 people|100=99+ people}} left
messages on your user board."
Steps to reproduce:
1. Install the Echo extension on your local test wiki
2. Sign into one of your accounts and send multiple messages (e.g 3)
to another account of yours
3. Sign into your other account and visit [[Special:Notifications]],
and receive this wrongly phrased message.
Change-Id: Idcdeacf73a1479b7dbb0146736e0f3e72b81041f
---
M UserBoard/i18n/en.json
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SocialProfile refs/changes/95/401195/1
diff --git a/UserBoard/i18n/en.json b/UserBoard/i18n/en.json
index 8cde24f..6529a17 100644
--- a/UserBoard/i18n/en.json
+++ b/UserBoard/i18n/en.json
@@ -58,7 +58,7 @@
"echo-category-title-social-msg": "User board messages",
"echo-pref-tooltip-social-msg": "Notify me when someone leaves a message on my user board.",
"notification-social-msg-send": "$1 just left a message on your user board.<br /><br />''$2''",
- "notification-social-msg-send-bundle": "{{PLURAL:$1|One person|$1 people|100=99+ people}} left messages on your user board.",
+ "notification-social-msg-send-bundle": "{{PLURAL:$1|One message|$1 messages|100=99+ messages}} have been left on your user board.",
"apihelp-socialprofile-send-message-description": "Send a message to a user's UserBoard.",
"apihelp-socialprofile-send-message-summary": "Send a message to a user's UserBoard.",
"apihelp-socialprofile-send-message-param-username": "The recipient's user name.",
--
To view, visit https://gerrit.wikimedia.org/r/401195
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idcdeacf73a1479b7dbb0146736e0f3e72b81041f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SocialProfile
Gerrit-Branch: master
Gerrit-Owner: SamanthaNguyen <***@gmail.com>
Change subject: UserBoard i18n: Fix phrasing of Echo notification bundle message
......................................................................
UserBoard i18n: Fix phrasing of Echo notification bundle message
This message has been phrased incorrectly, as it wrongly assumes
that each message is sent by a different person. The easiest way to
"fix" this error is to rephrase this message.
- New: "{{PLURAL:$1|One message|$1
messages|100=99+ messages}} have been left on your user board."
- Original: "{{PLURAL:$1|One person|$1 people|100=99+ people}} left
messages on your user board."
Steps to reproduce:
1. Install the Echo extension on your local test wiki
2. Sign into one of your accounts and send multiple messages (e.g 3)
to another account of yours
3. Sign into your other account and visit [[Special:Notifications]],
and receive this wrongly phrased message.
Change-Id: Idcdeacf73a1479b7dbb0146736e0f3e72b81041f
---
M UserBoard/i18n/en.json
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SocialProfile refs/changes/95/401195/1
diff --git a/UserBoard/i18n/en.json b/UserBoard/i18n/en.json
index 8cde24f..6529a17 100644
--- a/UserBoard/i18n/en.json
+++ b/UserBoard/i18n/en.json
@@ -58,7 +58,7 @@
"echo-category-title-social-msg": "User board messages",
"echo-pref-tooltip-social-msg": "Notify me when someone leaves a message on my user board.",
"notification-social-msg-send": "$1 just left a message on your user board.<br /><br />''$2''",
- "notification-social-msg-send-bundle": "{{PLURAL:$1|One person|$1 people|100=99+ people}} left messages on your user board.",
+ "notification-social-msg-send-bundle": "{{PLURAL:$1|One message|$1 messages|100=99+ messages}} have been left on your user board.",
"apihelp-socialprofile-send-message-description": "Send a message to a user's UserBoard.",
"apihelp-socialprofile-send-message-summary": "Send a message to a user's UserBoard.",
"apihelp-socialprofile-send-message-param-username": "The recipient's user name.",
--
To view, visit https://gerrit.wikimedia.org/r/401195
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idcdeacf73a1479b7dbb0146736e0f3e72b81041f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SocialProfile
Gerrit-Branch: master
Gerrit-Owner: SamanthaNguyen <***@gmail.com>