[MediaWiki-commits] [Gerrit] mediawiki...Timeless[master]: Remove fake element created before links so background align...

[SamanthaNguyen (Code Review)]

SamanthaNguyen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401188 )

Change subject: Remove fake element created before links so background aligns correctly
......................................................................

Remove fake element created before links so background aligns correctly

This rule seems to no longer apply to the skin in it's current state,
and seems to be causing problems with references. These rules are an issue
for that it creates a fake block element (which adds extra spacing at the
top), creates a static height, and pulls it up with a negative top margin.

It seems best to remove this CSS block.

Bug: T181490
Change-Id: Id109e42731202f0c6e1ef6ff8855617e0795b35d
---
M resources/screen-desktop.less
1 file changed, 0 insertions(+), 8 deletions(-)


git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Timeless refs/changes/88/401188/1

diff --git a/resources/screen-desktop.less b/resources/screen-desktop.less
index a056e3e..1727078 100644
--- a/resources/screen-desktop.less
+++ b/resources/screen-desktop.less
@@ -60,14 +60,6 @@
display: none;
}

-/* Add offset to make anchor links work with the fixed header */
-:target:before {
- content: '';
- display: block;
- height: @fixed-header-height;
- margin: -@fixed-header-height 0 0;
-}
-
.dropdown {
display: none !important;
}
--
To view, visit https://gerrit.wikimedia.org/r/401188
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id109e42731202f0c6e1ef6ff8855617e0795b35d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Timeless
Gerrit-Branch: master
Gerrit-Owner: SamanthaNguyen <***@gmail.com>

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/401188 )

Change subject: Remove fake element created before links so background aligns correctly
......................................................................


Remove fake element created before links so background aligns correctly

This rule seems to no longer apply to the skin in it's current state,
and seems to be causing problems with references. These rules are an issue
for that it creates a fake block element (which adds extra spacing at the
top), creates a static height, and pulls it up with a negative top margin.

It seems best to remove this CSS block.

Bug: T181490
Change-Id: Id109e42731202f0c6e1ef6ff8855617e0795b35d
---
M resources/screen-desktop.less
1 file changed, 0 insertions(+), 8 deletions(-)

Approvals:
jenkins-bot: Verified
Isarra: Looks good to me, approved



diff --git a/resources/screen-desktop.less b/resources/screen-desktop.less
index a056e3e..1727078 100644
--- a/resources/screen-desktop.less
+++ b/resources/screen-desktop.less
@@ -60,14 +60,6 @@
display: none;
}

-/* Add offset to make anchor links work with the fixed header */
-:target:before {
- content: '';
- display: block;
- height: @fixed-header-height;
- margin: -@fixed-header-height 0 0;
-}
-
.dropdown {
display: none !important;
}
--
To view, visit https://gerrit.wikimedia.org/r/401188
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id109e42731202f0c6e1ef6ff8855617e0795b35d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Timeless
Gerrit-Branch: master
Gerrit-Owner: SamanthaNguyen <***@gmail.com>
Gerrit-Reviewer: Isarra <***@gmail.com>
Gerrit-Reviewer: jenkins-bot <>