Umherirrender (Code Review)
2017-12-30 23:46:28 UTC
Hello Legoktm,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/401108
to review the following change.
Change subject: Revert "Add BlueSpiceAbout"
......................................................................
Revert "Add BlueSpiceAbout"
.gitmodules contains more submodules as added commit ids,
this leasves the repo in an unclean state
This reverts commit 385dbb885075a76df45d3d6bb8298947e353cc93.
Change-Id: Ia0de7f5a15ba8ab31e4598ae4c56d4da0259f649
---
M .gitmodules
D BlueSpiceAbout
2 files changed, 0 insertions(+), 92 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions refs/changes/08/401108/1
diff --git a/.gitmodules b/.gitmodules
index 3ed794a..4bf1fc4 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -178,10 +178,6 @@
path = BlogPage
url = https://gerrit.wikimedia.org/r/mediawiki/extensions/BlogPage
branch = .
-[submodule "BlueSpiceAbout"]
- path = BlueSpiceAbout
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/BlueSpiceAbout
- branch = .
[submodule "BlueSpiceArticleInfo"]
path = BlueSpiceArticleInfo
url = https://gerrit.wikimedia.org/r/mediawiki/extensions/BlueSpiceArticleInfo
@@ -3078,90 +3074,3 @@
path = wikihiero
url = https://gerrit.wikimedia.org/r/mediawiki/extensions/wikihiero
branch = .
-[submodule "BSSMWConnector"]
- path = BSSMWConnector
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/BSSMWConnector
-[submodule "BlueSpiceAbout"]
- path = BlueSpiceAbout
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/BlueSpiceAbout
-[submodule "BlueSpiceHideTitle"]
- path = BlueSpiceHideTitle
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/BlueSpiceHideTitle
-[submodule "BlueSpiceInsertCategory"]
- path = BlueSpiceInsertCategory
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/BlueSpiceInsertCategory
-[submodule "BlueSpiceInsertFile"]
- path = BlueSpiceInsertFile
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/BlueSpiceInsertFile
-[submodule "BlueSpiceInsertLink"]
- path = BlueSpiceInsertLink
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/BlueSpiceInsertLink
-[submodule "BlueSpiceInsertMagic"]
- path = BlueSpiceInsertMagic
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/BlueSpiceInsertMagic
-[submodule "BlueSpiceNamespaceCSS"]
- path = BlueSpiceNamespaceCSS
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/BlueSpiceNamespaceCSS
-[submodule "BlueSpicePageAccess"]
- path = BlueSpicePageAccess
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/BlueSpicePageAccess
-[submodule "BlueSpiceRSSFeeder"]
- path = BlueSpiceRSSFeeder
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/BlueSpiceRSSFeeder
-[submodule "BlueSpiceSaferEdit"]
- path = BlueSpiceSaferEdit
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/BlueSpiceSaferEdit
-[submodule "BlueSpiceUEModulePDF"]
- path = BlueSpiceUEModulePDF
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/BlueSpiceUEModulePDF
-[submodule "BlueSpiceUniversalExport"]
- path = BlueSpiceUniversalExport
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/BlueSpiceUniversalExport
-[submodule "BlueSpiceUsageTracker"]
- path = BlueSpiceUsageTracker
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/BlueSpiceUsageTracker
-[submodule "DataTypes"]
- path = DataTypes
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/DataTypes
-[submodule "Form"]
- path = Form
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/Form
-[submodule "GitGadgets"]
- path = GitGadgets
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/GitGadgets
-[submodule "GitHub"]
- path = GitHub
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/GitHub
-[submodule "MoveToCommons"]
- path = MoveToCommons
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/MoveToCommons
-[submodule "MoveToCommonsClient"]
- path = MoveToCommonsClient
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/MoveToCommonsClient
-[submodule "NumberOfComments"]
- path = NumberOfComments
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/NumberOfComments
-[submodule "Parsoid"]
- path = Parsoid
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/Parsoid
-[submodule "PreferencesList"]
- path = PreferencesList
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/PreferencesList
-[submodule "PreferencesMaster"]
- path = PreferencesMaster
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/PreferencesMaster
-[submodule "Recoin"]
- path = Recoin
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/Recoin
-[submodule "RelationLinks"]
- path = RelationLinks
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/RelationLinks
-[submodule "ThumbParser"]
- path = ThumbParser
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/ThumbParser
-[submodule "Vine"]
- path = Vine
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/Vine
-[submodule "WikidataEntitySuggester"]
- path = WikidataEntitySuggester
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/WikidataEntitySuggester
diff --git a/BlueSpiceAbout b/BlueSpiceAbout
deleted file mode 160000
index 2252a62..0000000
--- a/BlueSpiceAbout
+++ /dev/null
@@ -1 +0,0 @@
-Subproject commit 2252a625813debb0e3d368043eea4a98c3f8c455
--
To view, visit https://gerrit.wikimedia.org/r/401108
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia0de7f5a15ba8ab31e4598ae4c56d4da0259f649
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <***@web.de>
Gerrit-Reviewer: Legoktm <***@member.fsf.org>
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/401108
to review the following change.
Change subject: Revert "Add BlueSpiceAbout"
......................................................................
Revert "Add BlueSpiceAbout"
.gitmodules contains more submodules as added commit ids,
this leasves the repo in an unclean state
This reverts commit 385dbb885075a76df45d3d6bb8298947e353cc93.
Change-Id: Ia0de7f5a15ba8ab31e4598ae4c56d4da0259f649
---
M .gitmodules
D BlueSpiceAbout
2 files changed, 0 insertions(+), 92 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions refs/changes/08/401108/1
diff --git a/.gitmodules b/.gitmodules
index 3ed794a..4bf1fc4 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -178,10 +178,6 @@
path = BlogPage
url = https://gerrit.wikimedia.org/r/mediawiki/extensions/BlogPage
branch = .
-[submodule "BlueSpiceAbout"]
- path = BlueSpiceAbout
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/BlueSpiceAbout
- branch = .
[submodule "BlueSpiceArticleInfo"]
path = BlueSpiceArticleInfo
url = https://gerrit.wikimedia.org/r/mediawiki/extensions/BlueSpiceArticleInfo
@@ -3078,90 +3074,3 @@
path = wikihiero
url = https://gerrit.wikimedia.org/r/mediawiki/extensions/wikihiero
branch = .
-[submodule "BSSMWConnector"]
- path = BSSMWConnector
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/BSSMWConnector
-[submodule "BlueSpiceAbout"]
- path = BlueSpiceAbout
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/BlueSpiceAbout
-[submodule "BlueSpiceHideTitle"]
- path = BlueSpiceHideTitle
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/BlueSpiceHideTitle
-[submodule "BlueSpiceInsertCategory"]
- path = BlueSpiceInsertCategory
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/BlueSpiceInsertCategory
-[submodule "BlueSpiceInsertFile"]
- path = BlueSpiceInsertFile
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/BlueSpiceInsertFile
-[submodule "BlueSpiceInsertLink"]
- path = BlueSpiceInsertLink
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/BlueSpiceInsertLink
-[submodule "BlueSpiceInsertMagic"]
- path = BlueSpiceInsertMagic
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/BlueSpiceInsertMagic
-[submodule "BlueSpiceNamespaceCSS"]
- path = BlueSpiceNamespaceCSS
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/BlueSpiceNamespaceCSS
-[submodule "BlueSpicePageAccess"]
- path = BlueSpicePageAccess
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/BlueSpicePageAccess
-[submodule "BlueSpiceRSSFeeder"]
- path = BlueSpiceRSSFeeder
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/BlueSpiceRSSFeeder
-[submodule "BlueSpiceSaferEdit"]
- path = BlueSpiceSaferEdit
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/BlueSpiceSaferEdit
-[submodule "BlueSpiceUEModulePDF"]
- path = BlueSpiceUEModulePDF
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/BlueSpiceUEModulePDF
-[submodule "BlueSpiceUniversalExport"]
- path = BlueSpiceUniversalExport
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/BlueSpiceUniversalExport
-[submodule "BlueSpiceUsageTracker"]
- path = BlueSpiceUsageTracker
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/BlueSpiceUsageTracker
-[submodule "DataTypes"]
- path = DataTypes
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/DataTypes
-[submodule "Form"]
- path = Form
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/Form
-[submodule "GitGadgets"]
- path = GitGadgets
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/GitGadgets
-[submodule "GitHub"]
- path = GitHub
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/GitHub
-[submodule "MoveToCommons"]
- path = MoveToCommons
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/MoveToCommons
-[submodule "MoveToCommonsClient"]
- path = MoveToCommonsClient
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/MoveToCommonsClient
-[submodule "NumberOfComments"]
- path = NumberOfComments
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/NumberOfComments
-[submodule "Parsoid"]
- path = Parsoid
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/Parsoid
-[submodule "PreferencesList"]
- path = PreferencesList
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/PreferencesList
-[submodule "PreferencesMaster"]
- path = PreferencesMaster
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/PreferencesMaster
-[submodule "Recoin"]
- path = Recoin
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/Recoin
-[submodule "RelationLinks"]
- path = RelationLinks
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/RelationLinks
-[submodule "ThumbParser"]
- path = ThumbParser
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/ThumbParser
-[submodule "Vine"]
- path = Vine
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/Vine
-[submodule "WikidataEntitySuggester"]
- path = WikidataEntitySuggester
- url = https://gerrit.wikimedia.org/r/mediawiki/extensions/WikidataEntitySuggester
diff --git a/BlueSpiceAbout b/BlueSpiceAbout
deleted file mode 160000
index 2252a62..0000000
--- a/BlueSpiceAbout
+++ /dev/null
@@ -1 +0,0 @@
-Subproject commit 2252a625813debb0e3d368043eea4a98c3f8c455
--
To view, visit https://gerrit.wikimedia.org/r/401108
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia0de7f5a15ba8ab31e4598ae4c56d4da0259f649
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <***@web.de>
Gerrit-Reviewer: Legoktm <***@member.fsf.org>