Libraryupgrader (Code Review)
2017-12-30 02:10:31 UTC
Libraryupgrader has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400896 )
Change subject: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0
......................................................................
build: Updating mediawiki/mediawiki-codesniffer to 15.0.0
The following sniffs are failing and were disabled:
* Squiz.Scope.MethodScope.Missing
Change-Id: Id81fa79cfc06807a2d87fdec45b901f682ad709e
---
M .phpcs.xml
M composer.json
2 files changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PoolCounter refs/changes/96/400896/1
diff --git a/.phpcs.xml b/.phpcs.xml
index 94c9b66..f199774 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -2,7 +2,8 @@
<ruleset>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
- <exclude name="Squiz.Classes.ValidClassName.NotCamelCaps"/>
+ <exclude name="Squiz.Classes.ValidClassName.NotCamelCaps" />
+ <exclude name="Squiz.Scope.MethodScope.Missing" />
<exclude name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment"/>
</rule>
<file>.</file>
diff --git a/composer.json b/composer.json
index 6c45e79..f3cbcc4 100644
--- a/composer.json
+++ b/composer.json
@@ -2,7 +2,7 @@
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
"jakub-onderka/php-console-highlighter": "0.3.2",
- "mediawiki/mediawiki-codesniffer": "14.1.0",
+ "mediawiki/mediawiki-codesniffer": "15.0.0",
"mediawiki/minus-x": "0.2.1"
},
"scripts": {
--
To view, visit https://gerrit.wikimedia.org/r/400896
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id81fa79cfc06807a2d87fdec45b901f682ad709e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PoolCounter
Gerrit-Branch: master
Gerrit-Owner: Libraryupgrader <***@tools.wmflabs.org>
Gerrit-Reviewer: Libraryupgrader <***@tools.wmflabs.org>
Change subject: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0
......................................................................
build: Updating mediawiki/mediawiki-codesniffer to 15.0.0
The following sniffs are failing and were disabled:
* Squiz.Scope.MethodScope.Missing
Change-Id: Id81fa79cfc06807a2d87fdec45b901f682ad709e
---
M .phpcs.xml
M composer.json
2 files changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PoolCounter refs/changes/96/400896/1
diff --git a/.phpcs.xml b/.phpcs.xml
index 94c9b66..f199774 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -2,7 +2,8 @@
<ruleset>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
- <exclude name="Squiz.Classes.ValidClassName.NotCamelCaps"/>
+ <exclude name="Squiz.Classes.ValidClassName.NotCamelCaps" />
+ <exclude name="Squiz.Scope.MethodScope.Missing" />
<exclude name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment"/>
</rule>
<file>.</file>
diff --git a/composer.json b/composer.json
index 6c45e79..f3cbcc4 100644
--- a/composer.json
+++ b/composer.json
@@ -2,7 +2,7 @@
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
"jakub-onderka/php-console-highlighter": "0.3.2",
- "mediawiki/mediawiki-codesniffer": "14.1.0",
+ "mediawiki/mediawiki-codesniffer": "15.0.0",
"mediawiki/minus-x": "0.2.1"
},
"scripts": {
--
To view, visit https://gerrit.wikimedia.org/r/400896
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id81fa79cfc06807a2d87fdec45b901f682ad709e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PoolCounter
Gerrit-Branch: master
Gerrit-Owner: Libraryupgrader <***@tools.wmflabs.org>
Gerrit-Reviewer: Libraryupgrader <***@tools.wmflabs.org>