[MediaWiki-commits] [Gerrit] mediawiki...Newsletter[master]: Don't automatically add creator to publishers/subscribers in...

[Pppery (Code Review)]

Pppery has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401187 )

Change subject: Don't automatically add creator to publishers/subscribers in NewsletterDataUpdate
......................................................................

Don't automatically add creator to publishers/subscribers in NewsletterDataUpdate

When NewsletterDataUpdate runs, the Newsletter json page has already
been created, so doing this causes the page and the nl_publishers
database to disagree.

Change-Id: Ic31a4dc41a4736f6ce852ab933d669ee3c245b79
---
M includes/content/NewsletterDataUpdate.php
1 file changed, 0 insertions(+), 3 deletions(-)


git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Newsletter refs/changes/87/401187/1

diff --git a/includes/content/NewsletterDataUpdate.php b/includes/content/NewsletterDataUpdate.php
index ee5dc86..1284315 100644
--- a/includes/content/NewsletterDataUpdate.php
+++ b/includes/content/NewsletterDataUpdate.php
@@ -67,9 +67,6 @@
return false;
}

- $newsletter->subscribe( $this->user );
- $store->addPublisher( $newsletter, [ $this->user->getId() ] );
-
return $newsletter;
}
--
To view, visit https://gerrit.wikimedia.org/r/401187
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic31a4dc41a4736f6ce852ab933d669ee3c245b79
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Newsletter
Gerrit-Branch: master
Gerrit-Owner: Pppery <***@olum.org>