Discussion:
[MediaWiki-commits] [Gerrit] mediawiki...Newsletter[master]: Fix bug that causes newsletter names in database to contain ...
Pppery (Code Review)
2017-12-31 03:51:32 UTC
Permalink
Pppery has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401114 )

Change subject: Fix bug that causes newsletter names in database to contain namespace name
......................................................................

Fix bug that causes newsletter names in database to contain namespace name

This was introduced by mistake in 39eac922ee889f67d8ba0de97d2c80fc09e41db2

Bug: T183752
Change-Id: I544a3034c7f25132d9916fe99bde0791a7c1a6fa
---
M includes/content/NewsletterDataUpdate.php
1 file changed, 1 insertion(+), 1 deletion(-)


git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Newsletter refs/changes/14/401114/1

diff --git a/includes/content/NewsletterDataUpdate.php b/includes/content/NewsletterDataUpdate.php
index 4df676d..ee5dc86 100644
--- a/includes/content/NewsletterDataUpdate.php
+++ b/includes/content/NewsletterDataUpdate.php
@@ -81,7 +81,7 @@
$newsletter = Newsletter::newFromName( $this->title->getText() );

$formData = [
- 'Name' => $this->title->getFullText(),
+ 'Name' => $this->title->getText(),
'Description' => $this->content->getDescription(),
'MainPage' => $this->content->getMainPage()
];
--
To view, visit https://gerrit.wikimedia.org/r/401114
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I544a3034c7f25132d9916fe99bde0791a7c1a6fa
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Newsletter
Gerrit-Branch: master
Gerrit-Owner: Pppery <***@olum.org>
jenkins-bot (Code Review)
2017-12-31 12:17:20 UTC
Permalink
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/401114 )

Change subject: Fix bug that causes newsletter names in database to contain namespace name
......................................................................


Fix bug that causes newsletter names in database to contain namespace name

This was introduced by mistake in 39eac922ee889f67d8ba0de97d2c80fc09e41db2

Bug: T183752
Change-Id: I544a3034c7f25132d9916fe99bde0791a7c1a6fa
---
M includes/content/NewsletterDataUpdate.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
01tonythomas: Looks good to me, approved
jenkins-bot: Verified



diff --git a/includes/content/NewsletterDataUpdate.php b/includes/content/NewsletterDataUpdate.php
index 4df676d..ee5dc86 100644
--- a/includes/content/NewsletterDataUpdate.php
+++ b/includes/content/NewsletterDataUpdate.php
@@ -81,7 +81,7 @@
$newsletter = Newsletter::newFromName( $this->title->getText() );

$formData = [
- 'Name' => $this->title->getFullText(),
+ 'Name' => $this->title->getText(),
'Description' => $this->content->getDescription(),
'MainPage' => $this->content->getMainPage()
];
--
To view, visit https://gerrit.wikimedia.org/r/401114
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I544a3034c7f25132d9916fe99bde0791a7c1a6fa
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Newsletter
Gerrit-Branch: master
Gerrit-Owner: Pppery <***@olum.org>
Gerrit-Reviewer: 01tonythomas <***@gmail.com>
Gerrit-Reviewer: Addshore <***@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
Loading...