[MediaWiki-commits] [Gerrit] mediawiki...BlueSpiceSaferEdit[master]: Add php-parallel-lint, grunt-jsonlint and grunt-banana-checker

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401169 )

Change subject: Add php-parallel-lint, grunt-jsonlint and grunt-banana-checker
......................................................................

Add php-parallel-lint, grunt-jsonlint and grunt-banana-checker

jsonlint and banana-checker will test for valid i18n files
php-lint will test for valid php files

Change-Id: Ia4910827b5e7c5cb16e7fa0925a438b25b7c023e
---
A Gruntfile.js
M composer.json
A package.json
3 files changed, 38 insertions(+), 8 deletions(-)


git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceSaferEdit refs/changes/69/401169/1

diff --git a/Gruntfile.js b/Gruntfile.js
new file mode 100644
index 0000000..ea67e84
--- /dev/null
+++ b/Gruntfile.js
@@ -0,0 +1,19 @@
+module.exports = function ( grunt ) {
+ grunt.loadNpmTasks( 'grunt-jsonlint' );
+ grunt.loadNpmTasks( 'grunt-banana-checker' );
+
+ var conf = grunt.file.readJSON( 'extension.json' );
+ grunt.initConfig( {
+ banana: conf.MessagesDirs,
+ jsonlint: {
+ all: [
+ '**/*.json',
+ '!node_modules/**',
+ '!vendor/**'
+ ]
+ }
+ } );
+
+ grunt.registerTask( 'test', [ 'jsonlint', 'banana' ] );
+ grunt.registerTask( 'default', 'test' );
+};
diff --git a/composer.json b/composer.json
index b9ea082..7a568dc 100644
--- a/composer.json
+++ b/composer.json
@@ -6,14 +6,14 @@
"require": {
"composer/installers": "~1.0"
},
- "require-dev": {
- "jakub-onderka/php-parallel-lint": "0.9.2",
- "jakub-onderka/php-console-highlighter": "0.3.2"
- },
- "scripts": {
- "test": [
- "parallel-lint . --exclude vendor --exclude node_modules"
- ]
+ "require-dev": {
+ "jakub-onderka/php-parallel-lint": "0.9.2",
+ "jakub-onderka/php-console-highlighter": "0.3.2"
+ },
+ "scripts": {
+ "test": [
+ "parallel-lint . --exclude vendor --exclude node_modules"
+ ]
},
"autoload" : {
"files": [ "SaferEdit.class.php" ],
diff --git a/package.json b/package.json
new file mode 100644
index 0000000..10fa9bc
--- /dev/null
+++ b/package.json
@@ -0,0 +1,11 @@
+{
+ "private": true,
+ "scripts": {
+ "test": "grunt test"
+ },
+ "devDependencies": {
+ "grunt": "1.0.1",
+ "grunt-banana-checker": "0.6.0",
+ "grunt-jsonlint": "1.1.0"
+ }
+}
--
To view, visit https://gerrit.wikimedia.org/r/401169
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia4910827b5e7c5cb16e7fa0925a438b25b7c023e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceSaferEdit
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <***@web.de>

[Umherirrender (Code Review)]

Umherirrender has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/401169 )

Change subject: Add grunt-jsonlint and grunt-banana-checker
......................................................................


Add grunt-jsonlint and grunt-banana-checker

jsonlint and banana-checker will test for valid i18n files
Always use tabs in composer.json

Change-Id: Ia4910827b5e7c5cb16e7fa0925a438b25b7c023e
---
A Gruntfile.js
M composer.json
A package.json
3 files changed, 38 insertions(+), 8 deletions(-)

Approvals:
Umherirrender: Verified; Looks good to me, approved



diff --git a/Gruntfile.js b/Gruntfile.js
new file mode 100644
index 0000000..ea67e84
--- /dev/null
+++ b/Gruntfile.js
@@ -0,0 +1,19 @@
+module.exports = function ( grunt ) {
+ grunt.loadNpmTasks( 'grunt-jsonlint' );
+ grunt.loadNpmTasks( 'grunt-banana-checker' );
+
+ var conf = grunt.file.readJSON( 'extension.json' );
+ grunt.initConfig( {
+ banana: conf.MessagesDirs,
+ jsonlint: {
+ all: [
+ '**/*.json',
+ '!node_modules/**',
+ '!vendor/**'
+ ]
+ }
+ } );
+
+ grunt.registerTask( 'test', [ 'jsonlint', 'banana' ] );
+ grunt.registerTask( 'default', 'test' );
+};
diff --git a/composer.json b/composer.json
index b9ea082..7a568dc 100644
--- a/composer.json
+++ b/composer.json
@@ -6,14 +6,14 @@
"require": {
"composer/installers": "~1.0"
},
- "require-dev": {
- "jakub-onderka/php-parallel-lint": "0.9.2",
- "jakub-onderka/php-console-highlighter": "0.3.2"
- },
- "scripts": {
- "test": [
- "parallel-lint . --exclude vendor --exclude node_modules"
- ]
+ "require-dev": {
+ "jakub-onderka/php-parallel-lint": "0.9.2",
+ "jakub-onderka/php-console-highlighter": "0.3.2"
+ },
+ "scripts": {
+ "test": [
+ "parallel-lint . --exclude vendor --exclude node_modules"
+ ]
},
"autoload" : {
"files": [ "SaferEdit.class.php" ],
diff --git a/package.json b/package.json
new file mode 100644
index 0000000..10fa9bc
--- /dev/null
+++ b/package.json
@@ -0,0 +1,11 @@
+{
+ "private": true,
+ "scripts": {
+ "test": "grunt test"
+ },
+ "devDependencies": {
+ "grunt": "1.0.1",
+ "grunt-banana-checker": "0.6.0",
+ "grunt-jsonlint": "1.1.0"
+ }
+}
--
To view, visit https://gerrit.wikimedia.org/r/401169
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia4910827b5e7c5cb16e7fa0925a438b25b7c023e
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/BlueSpiceSaferEdit
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <***@web.de>
Gerrit-Reviewer: Ljonka <***@gmail.com>
Gerrit-Reviewer: Mglaser <***@hallowelt.biz>
Gerrit-Reviewer: Pwirth <***@hallowelt.biz>
Gerrit-Reviewer: Robert Vogel <***@hallowelt.biz>
Gerrit-Reviewer: Umherirrender <***@web.de>