Discussion:
[MediaWiki-commits] [Gerrit] mediawiki...Form[master]: Add php-parallel-lint and grunt-jsonlint
Umherirrender (Code Review)
2017-12-31 11:35:11 UTC
Permalink
Umherirrender has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401162 )

Change subject: Add php-parallel-lint and grunt-jsonlint
......................................................................

Add php-parallel-lint and grunt-jsonlint

jsonlint will test for valid i18n files
php-lint will test for valid php files

Change-Id: I27b0d36c1ba2ba05708401bbff5694f0ec0d6f2a
---
A .gitignore
A Gruntfile.js
A composer.json
A package.json
4 files changed, 44 insertions(+), 0 deletions(-)


git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Form refs/changes/62/401162/1

diff --git a/.gitignore b/.gitignore
new file mode 100644
index 0000000..db8a779
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1,3 @@
+/node_modules
+/vendor
+/composer.lock
diff --git a/Gruntfile.js b/Gruntfile.js
new file mode 100644
index 0000000..47d544d
--- /dev/null
+++ b/Gruntfile.js
@@ -0,0 +1,19 @@
+module.exports = function ( grunt ) {
+ grunt.loadNpmTasks( 'grunt-jsonlint' );
+// grunt.loadNpmTasks( 'grunt-banana-checker' );
+
+// var conf = grunt.file.readJSON( 'extension.json' );
+ grunt.initConfig( {
+// banana: conf.MessagesDirs,
+ jsonlint: {
+ all: [
+ '**/*.json',
+ '!node_modules/**',
+ '!vendor/**'
+ ]
+ }
+ } );
+
+ grunt.registerTask( 'test', [ 'jsonlint'/*, 'banana'*/ ] );
+ grunt.registerTask( 'default', 'test' );
+};
diff --git a/composer.json b/composer.json
new file mode 100644
index 0000000..aebd773
--- /dev/null
+++ b/composer.json
@@ -0,0 +1,11 @@
+{
+ "require-dev": {
+ "jakub-onderka/php-parallel-lint": "0.9.2",
+ "jakub-onderka/php-console-highlighter": "0.3.2"
+ },
+ "scripts": {
+ "test": [
+ "parallel-lint . --exclude vendor --exclude node_modules"
+ ]
+ }
+}
diff --git a/package.json b/package.json
new file mode 100644
index 0000000..10fa9bc
--- /dev/null
+++ b/package.json
@@ -0,0 +1,11 @@
+{
+ "private": true,
+ "scripts": {
+ "test": "grunt test"
+ },
+ "devDependencies": {
+ "grunt": "1.0.1",
+ "grunt-banana-checker": "0.6.0",
+ "grunt-jsonlint": "1.1.0"
+ }
+}
--
To view, visit https://gerrit.wikimedia.org/r/401162
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I27b0d36c1ba2ba05708401bbff5694f0ec0d6f2a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Form
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <***@web.de>
jenkins-bot (Code Review)
2017-12-31 11:42:35 UTC
Permalink
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/401162 )

Change subject: Add php-parallel-lint and grunt-jsonlint
......................................................................


Add php-parallel-lint and grunt-jsonlint

jsonlint will test for valid i18n files
php-lint will test for valid php files

Change-Id: I27b0d36c1ba2ba05708401bbff5694f0ec0d6f2a
---
A .gitignore
A Gruntfile.js
A composer.json
A package.json
4 files changed, 44 insertions(+), 0 deletions(-)

Approvals:
Umherirrender: Looks good to me, approved
jenkins-bot: Verified



diff --git a/.gitignore b/.gitignore
new file mode 100644
index 0000000..db8a779
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1,3 @@
+/node_modules
+/vendor
+/composer.lock
diff --git a/Gruntfile.js b/Gruntfile.js
new file mode 100644
index 0000000..47d544d
--- /dev/null
+++ b/Gruntfile.js
@@ -0,0 +1,19 @@
+module.exports = function ( grunt ) {
+ grunt.loadNpmTasks( 'grunt-jsonlint' );
+// grunt.loadNpmTasks( 'grunt-banana-checker' );
+
+// var conf = grunt.file.readJSON( 'extension.json' );
+ grunt.initConfig( {
+// banana: conf.MessagesDirs,
+ jsonlint: {
+ all: [
+ '**/*.json',
+ '!node_modules/**',
+ '!vendor/**'
+ ]
+ }
+ } );
+
+ grunt.registerTask( 'test', [ 'jsonlint'/*, 'banana'*/ ] );
+ grunt.registerTask( 'default', 'test' );
+};
diff --git a/composer.json b/composer.json
new file mode 100644
index 0000000..aebd773
--- /dev/null
+++ b/composer.json
@@ -0,0 +1,11 @@
+{
+ "require-dev": {
+ "jakub-onderka/php-parallel-lint": "0.9.2",
+ "jakub-onderka/php-console-highlighter": "0.3.2"
+ },
+ "scripts": {
+ "test": [
+ "parallel-lint . --exclude vendor --exclude node_modules"
+ ]
+ }
+}
diff --git a/package.json b/package.json
new file mode 100644
index 0000000..10fa9bc
--- /dev/null
+++ b/package.json
@@ -0,0 +1,11 @@
+{
+ "private": true,
+ "scripts": {
+ "test": "grunt test"
+ },
+ "devDependencies": {
+ "grunt": "1.0.1",
+ "grunt-banana-checker": "0.6.0",
+ "grunt-jsonlint": "1.1.0"
+ }
+}
--
To view, visit https://gerrit.wikimedia.org/r/401162
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I27b0d36c1ba2ba05708401bbff5694f0ec0d6f2a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Form
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <***@web.de>
Gerrit-Reviewer: Umherirrender <***@web.de>
Gerrit-Reviewer: jenkins-bot <>
Loading...